search

stepeos / pycarmodel_calibration

Calibration tool for the EIDM car following model
GNU General Public License v3.0
4 stars 0 forks source link

Usage of traffic_light_time #8

Open Domsall opened 3 months ago

Domsall commented 3 months ago

traffic_light_time has a default value of 60. The config-file of the tl intersection has a traffic_light_time value of -1. The config-file of the non-tl intersection has a traffic_light_time value of 1.

The code used to always include the following function:

https://github.com/stepeos/pycarmodel_calibration/blob/3765fa2f8637e3375fe0df831e60800cbd035dea/carmodel_calibration/control_program/simulation_handler.py#L131-L133

Now, this is only called, when traffic_light_time exists in the config file (used to not exist). And with the traffic_light_time value of the tl-intersection being -1, this function would not be called here, too.

https://github.com/stepeos/pycarmodel_calibration/blob/3765fa2f8637e3375fe0df831e60800cbd035dea/carmodel_calibration/control_program/simulation_handler.py#L128-L130

Is this the correct behavior? My current code always calls this function.

Domsall commented 2 months ago

@stepeos Could you take the time and check this together with the pull request?