Cleanup_post_views_with_test

[fflorent-01]

Most noteble in this pull request:

• Added a custom JSON renderer
• Added a custom error handler
• Refactored auth_views and auth_views test suite
• Changes have been made to the model.py file.

Majors noticed TODOS:

• password validation (stricter rules)
• phone validation (this one is trickey. I know Canadian/US standards)

Notes

• There is a verbose_name for fields that maybe we should leverage for frontend. (I added them to the User model so we migth test it.)
• Trying to harmonized quotes to be double quotes per default. So single quote would be reserved for special cases.
• Trying to avoid having NULL values in the DB where possible.

List of changes

.gitignore

• Added migrations to exclusion (only 0001_initial.py and init.py should remain)
• *** Need to be cleaned up / reorganized in a sensible order/grouping

docker-compose-development.yml

• Adjusted next build context and docker file location
• Autoformated file

.vscode/settings.json

• Modified sonalint settings t exclude pypoetry modules when reporting errors

backend/pyproject.toml

• Added pillow for image manipulation support.

backend/api/exception_handler.py

• Added a custom jasma_exception_handler that will act as the primary error handler.
• Mostly it takes build-in DRF error (and eventually other errors) and format then in a format so that each error becomes a dictionary: {"attr": , "code": , "message": } and this get appended to the response "errors" list in response.data.

backend/api/models.py

• One of the most heavyly edited file.
• This brings a lot of breaking at the moment but will get fixed as I move on different view functions.
• *Removed most null=True
• Added related_name to most related field (allow to call the field both ways more easily (ex: user.posts retrun list of user's posts in the user field has "related_name=posts".
• str have been brough to f-string format for readbility/editability
• format_xxx_dict removed as this should be achieved using serializer
• Some TODOs will need to be reviewed as decisions should be made.
• User
  • email: max from 50 => 254 (theritical max)
  • recovery_email: max from 55 => 254 (theritical max)
  • after_create operations have been moded to the save overwrite
  • total_created_posts / total_created_comments / total_created_ads have been added as both class method and instance methods
• UserProfile
  • profile_pic_url => I was thinking about using the ImageField to manage it.
• Hashtag
  • This one will need love I think we should use auto id field along with an attribute like name or string or some other
  • It is dangerous for data integrity to accept editable pk
• Post
  • Hastag creation have been moved to the save method overwrite. Still need testing.

backend/api/renderers.py

• Add JasmaJSONRenderer as primary renderer for json Responses. Will format response.data = {"success": bool, "message": "", "data": {}, "errors": []}

backend/api/serializers.py

• I added a bunch of serializers based on format_xxx_dict functions. Will be adjusted as we move along the views.

backend/api/urls.py

• Added names to routes for reverse functionality in testing.

backend/api/tests/test_auth_views.py

• New test suite for auth_views.py should be fully functionnal.

backend/api/views/auth_views.py

• Cleaned up and modified to be rest_framework compliant and functional

backend/api/views/post_views.py

• Don't take too much notice untill next merge

backend/django_server/settings.py

• *** Need to be cleaned up / reorganized in a sensible order/grouping
• Added REST_FRAMEWORK arguments
• Removed old sqlite config as we shouldn't really be using those anymore
• AUTHENTICATION_BACKENDS custom backend should at least precede default one to take precedence.

compose/local/django/requirements.txt

• Updated for pillow package. Migth need cleanup in the future.

compose/local/next/Dockerfile

• Next Docker file move to the compose directory
• Probably needs cleaning, especially since we have a .env file for this.

frontend/package.json

• SET replaced by export because it was triggering an error during build process.

[steph-koopmanschap]

Please add all your TODOs in the issues not in the PR. The PR should be for changes only.

If I am correct this is your issue/task. jasma/issues/65 Comment your TODO;s there. Or create a seperate issue for each todo. It's up to you how you wanna organize it.

You can create a checkbox like this:

• [ ] task one
• [ ] task two
• [ ] etc

Then in the PR just link to the issue for the todos.