Fails to build on Xcode 10.2 beta 1

stephan-tolksdorf / STULabel

A faster and more flexible label view for iOS

Other

120 stars 29 forks source link

Fails to build on Xcode 10.2 beta 1 #3

Closed b3ll closed 5 years ago

b3ll commented 5 years ago

Some new C++ stuff seems to have been changed but I don't really understand a lot of the template stuff you wrote :P

Any chance you could take a look?

Thanks!

STULabel/STULabel/Internal/NSStringRef.hpp:105:41: note: in instantiation of exception specification for 'operator _NSRange<_NSRange, unsigned long, 0>' requested here
        copyUTF16Chars_slowPath(NSRange(utf16IndexRange), out.begin());

stephan-tolksdorf commented 5 years ago

Thanks for the report! I'll take a look later today.

stephan-tolksdorf commented 5 years ago

I've fixed the errors caused by the casts and some other warnings. However, there seems to be a new bug in the Swift compiler that affects the overloaded initializers of STUBackgroundAttribute and STUTextHighlightStyleBuilder. If you're using Swift, you can temporarily work around these bugs e.g. by giving the closure arguments in the respective .overlay.swift extensions a name and changing the call sites accordingly.

I didn't yet have a chance to test STULabel on iOS 12.2. Please let me know when you spot an issue.

stephan-tolksdorf commented 5 years ago

I've created a Swift JIRA ticket: https://bugs.swift.org/browse/SR-9785

b3ll commented 5 years ago

Thanks so much for fixing that! I'll give some tests on device but they seem OK currently