stephane-caron / pink

Python inverse kinematics based on Pinocchio
Apache License 2.0
169 stars 11 forks source link

Numerical stability of Draco3 example #56

Closed stephane-caron closed 1 year ago

stephane-caron commented 1 year ago

@ymontmarin I just tested the new linear holonomic task on the humanoid_draco3.py example, and it seems it has become less numerically stable:

https://github.com/tasts-robots/pink/assets/1189580/d0f2c9f1-b463-49a5-8c6f-6aeeef0a0002

(The first run uses the latest version from PyPI, the second run is the current master branch.)

I don't think the gains should be reduced for the new task formulation? Or maybe this is because we are now including the free flyer in the task, whereas it was just q_2 = -q_1 before?

stephane-caron commented 1 year ago

Fixed in https://github.com/tasts-robots/pink/pull/58