search

stephane-monnot / react-vertical-timeline

Vertical timeline for React.js
https://stephane-monnot.github.io/react-vertical-timeline/
MIT License
1.07k stars 158 forks source link

lineColor prop #92

Closed avgupta456 closed 2 years ago

avgupta456 commented 3 years ago

I added a prop for lineColor, and used CSS variables to update the class.

closes #66

codecov-io commented 3 years ago

Codecov Report

Merging #92 (5854503) into master (9524971) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #92   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           14        16    +2     
  Branches         5         5           
=========================================
+ Hits            14        16    +2
Impacted Files Coverage Δ
src/VerticalTimeline.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9524971...5854503. Read the comment docs.

AndreiPisica commented 3 years ago

why isn't this merged?

FUSAKLA commented 3 years ago

+1 I'd like to change dynamically the line color to align with the dark/light theme and using only static CSS without access to the elements does not allow me to do this :/

max-deathray commented 3 years ago

+1 I would love this feature also! 💯

jorpilo commented 3 years ago

+1 This would be really good, please merge

Notaduck commented 2 years ago

@stephane-monnot is this something which is going to implemented?