search

stephane-monnot / react-vertical-timeline

Vertical timeline for React.js
https://stephane-monnot.github.io/react-vertical-timeline/
MIT License
1.07k stars 158 forks source link

Change is-hidden to vertical-timeline-is-hidden to avoid naming conflict #97

Open dbudwin opened 3 years ago

dbudwin commented 3 years ago

This issue stemmed from bug #95 related to jumping scrolling in SPA's that use Bulma. This is implementing the suggested fix.

This changes the major version from 3 to 4. I figured it could be considered a breaking change if users of this package are relying upon the old is-hidden CSS property.

Co-authored-by: Stéphane Monnot monnot.stephane@gmail.com

codecov-io commented 3 years ago

Codecov Report

Merging #97 (08c8cbb) into master (9524971) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #97   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           14        14           
  Branches         5         5           
=========================================
  Hits            14        14
Impacted Files Coverage Δ
src/VerticalTimelineElement.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9524971...08c8cbb. Read the comment docs.