stephane-r / holoplay-pwa

Web app using Invidious API for listening Youtube audio source.
https://app.holoplay.io
107 stars 16 forks source link

fix, feat: multiple issue to-do list #86

Open bfahrenfort opened 8 months ago

bfahrenfort commented 8 months ago

Hi, I love the project!

Just wanted to document what I'd like to contribute soon. Each will be a separate PR. Please let me know if any of these are being worked on already or if you have implementation tips/design requirements!

stephane-r commented 8 months ago

Hey @bfahrenfort

Thank you for your todo-list, several points are interesting :)

I can create an issue with a technical part if you wish, for each of the points raised. I have a question regarding import/export, point 1: I'm not sure I completely understood it 😄

Thank you again 👍

bfahrenfort commented 8 months ago

I'll create PRs as I implement them, no need to clutter the repo right now.

As for point 1 of import/export, if you refresh the page after having changed the volume, the volume will go back to 100%. I have very loud headphones so this is uncomfortable every time I open a new session. I want to save it in the same way settings are to persist across refreshes (cookies? Haven't looked at the codebase too deeply yet).

stephane-r commented 8 months ago

Aaaah yes for volume, good idea. We can add other switch in Settings/Player section.

All settings are save in localStorage by using local "database" with localstoragedb package. You can see this part in src/database folder. You'll need to create new migration for add volume.

Thank you !