search

stephane-vanraes / renderless-svelte

A collection of renderless Svelte components
MIT License
277 stars 11 forks source link

Add close promise on modal #11

Closed MacFJA closed 3 years ago

MacFJA commented 3 years ago

This PR add Promise on the modal closing, which allow to trigger/chain action.

stephane-vanraes commented 3 years ago

Thank you for this addition (and fixing the typos). I like the idea of returning a promise here 👍 My TS typing is rather rusty, do you know how to fix the type for this function in index.ts ?

MacFJA commented 3 years ago

Never use Typescript that much myself, but this should be good 😅

stephane-vanraes commented 3 years ago

Guess that should be ok, released in v1.4.2 Thanks 👍