code cleanups - Githubissues

stephane / libmodbus

A Modbus library for Linux, Mac OS, FreeBSD and Windows

http://libmodbus.org

GNU Lesser General Public License v2.1

3.44k stars 1.75k forks source link

code cleanups #604

Closed merkaG closed 2 years ago

merkaG commented 2 years ago

some code cleanups:

unnecessary errno settings for malloc fails.
set ctx to NULL after free calls.

cla-bot[bot] commented 2 years ago

We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please fill https://forms.gle/5635zjphDo5JEJQSA to get yourself added.

stephane commented 2 years ago

This code is old and my not sure about the initial reasons (or may be it's useless these days) but:

I think errno settings were necessary because a successful free after the malloc failure would unset it.
some weird/old systems doesn't set pointer to null on free calls.