search

stephanenicolas / robospice

Repo of the Open Source Android library : RoboSpice. RoboSpice is a modular android library that makes writing asynchronous long running tasks easy. It is specialized in network requests, supports caching and offers REST requests out-of-the box using extension modules.
Apache License 2.0
2.95k stars 545 forks source link

Attended comments about commit eb2b8b45e0ff768f814da8f6d788e4d44a1a5d2e. #340

Closed nkeskinov closed 10 years ago

nkeskinov commented 10 years ago

Would this be a more proper way?

nkeskinov commented 10 years ago

Created issue #341 for the PR.

stephanenicolas commented 10 years ago

Has this been merged ? Can it be closed ? If you need a review, please squash a ping me / team.

Thx !

nkeskinov commented 10 years ago

@stephanenicolas The last commits you can see are the nearest to squashing I could get. The merge commit 94dbd66 has no changes, but it had to be here because the previous commits were reverted.

About the functionality, it lacks tests, as discussed by email. However, I can see no simple way of mocking a ListView that would force scroll behavior in order to check if the wrapped OnScrollListener methods were called. The reason for this is that all ListView's methods are private and many things are checked (due to optimization) before the OnScrollListener's methods are called. Ideas are welcome.

stephanenicolas commented 10 years ago

Hi @nikola,

I Will have a look at it next week.

Stéphane Le 2014-07-18 15:08, "Nikola Keskinov" notifications@github.com a écrit :

@stephanenicolas https://github.com/stephanenicolas The last commits you can see are the nearest to squashing I could get. The merge commit 94dbd66 https://github.com/stephanenicolas/robospice/commit/94dbd66 has no changes, but it had to be here because the previous comments were reverted.

About the functionality, it lacks tests, as discussed by email. However, I can see no simple way of mocking a ListView that would force scroll behavior in order to check if the wrapped OnScrollListener methods were called. Ideas are welcome. The reason for this is that all ListView's methods are private and many things are checked (due to optimization) before the OnScrollListener's methods are called.

— Reply to this email directly or view it on GitHub https://github.com/stephanenicolas/robospice/pull/340#issuecomment-49468345 .

stephanenicolas commented 10 years ago

Hi @nkeskinov , sorry for the delay, it took me a while to have an eye on this PR.

I did, and added tests. As soon as the build passes, I will merge it. I hope to release asap.