SpiceManager.execute bug?

[jdulaney]

I was looking through the source code and saw the following:

    /**
     * Execute a request, without using cache. No result from cache will be
     * returned. The method {@link SpiceRequest#loadDataFromNetwork()} will
     * always be invoked. The result will not be stored in cache.
     * @param request
     *            the request to execute.
     * @param requestListener
     *            the listener to notify when the request will finish.
     */
    public <T> void execute(final SpiceRequest<T> request, final RequestListener<T> requestListener) {
        final CachedSpiceRequest<T> cachedSpiceRequest = new CachedSpiceRequest<T>(request, null, DurationInMillis.ALWAYS_RETURNED);
        execute(cachedSpiceRequest, requestListener);
    }

The javadoc says that the cache is never used, but the CachedSpiceRequest uses DurationInMillis.ALWAYS_RETURNED. Shouldn't it be DurationInMillis.ALWAYS_EXPIRED ?

Am I missing something?

Location: SpiceManger.java:443 Robospice 1.4.14

[nkeskinov]

It's irrelevant, actually, because you have a null cache key.