stephanenicolas / toothpick

A scope tree based Dependency Injection (DI) library for Java / Kotlin / Android.
Apache License 2.0
1.12k stars 115 forks source link

Wrong lambda code in wiki #357

Closed ppsirker closed 5 years ago

ppsirker commented 5 years ago

https://github.com/stephanenicolas/toothpick/wiki/Modules-&-Bindings#configuration-lambda Incorrect lambda expression: Scope s = Toothpick.openScope(obj, { scope -> scope.installModules(new Module() {{ bind(IFoo.class).toInstance(new Foo()); bind(IBar.class).to(Bar.class); }})}); corrected Scope s = Toothpick.openScope(obj, scope -> scope.installModules(new Module() {{ bind(IFoo.class).toInstance(new Foo()); bind(IBar.class).to(Bar.class); }})); There is an extra pair of braces.

stephanenicolas commented 5 years ago

Thx ! @dlemures do you mind to fix it please ?

On Fri, Aug 16, 2019, 19:45 Partha Pratim Sirker, notifications@github.com wrote:

https://github.com/stephanenicolas/toothpick/wiki/Modules-&-Bindings#configuration-lambda Incorrect lambda expression: Scope s = Toothpick.openScope(obj, { scope -> scope.installModules(new Module() {{ bind(IFoo.class).toInstance(new Foo()); bind(IBar.class).to(Bar.class); }})}); corrected Scope s = Toothpick.openScope(obj, scope -> scope.installModules(new Module() {{ bind(IFoo.class).toInstance(new Foo()); bind(IBar.class).to(Bar.class); }})); There is an extra pair of braces.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/stephanenicolas/toothpick/issues/357?email_source=notifications&email_token=AAN7PXPPWUJBGIKYI7Y6H4TQE5C3TA5CNFSM4IMNXOA2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HFYEHPQ, or mute the thread https://github.com/notifications/unsubscribe-auth/AAN7PXOAWUBKWXPO4A52FBDQE5C3TANCNFSM4IMNXOAQ .

stephanenicolas commented 5 years ago

I did. Thx @ppsirker

dlemures commented 5 years ago

Thx for the suggestion and fix!

On Fri, Aug 16, 2019, 5:49 PM Stéphane Nicolas notifications@github.com wrote:

I did. Thx @ppsirker https://github.com/ppsirker

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/stephanenicolas/toothpick/issues/357?email_source=notifications&email_token=ABMURZLGI46BMFHSQPRH3OTQE5DILA5CNFSM4IMNXOA2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4P7WXA#issuecomment-522189660, or mute the thread https://github.com/notifications/unsubscribe-auth/ABMURZK6OBMAKZERBH5K4YTQE5DILANCNFSM4IMNXOAQ .