Prevent releasable factory cleanup

stephanenicolas / toothpick

A scope tree based Dependency Injection (DI) library for Java / Kotlin / Android.

Apache License 2.0

1.12k stars 115 forks source link

Prevent releasable factory cleanup #400

Closed powturns closed 4 years ago

powturns commented 4 years ago

Only garbage collect the factory or provider factory if the InternalProvider is not releasable. Otherwise, after being released the provider will not have a factory available to re-create the instance.

Fixes #398

coveralls commented 4 years ago

Coverage increased (+0.008%) to 95.583% when pulling a1817c5cac9055c900dfece383fde60275d0519f on 51systems:release_cleanup into b13c9062d1b1cac010f163028ce7e97df8272070 on stephanenicolas:master.

powturns commented 4 years ago

Is there anything I can do to help this PR along?

dlemures commented 4 years ago

Merged! Thx @51systems

Targeting next release

Sorry for the delay, we have been a little busy on our end.