Form history lost under some circumstances with a test case

stephanmahieu / formhistorycontrol-2

A browser Add-On to View and Manage form history entries (adaptation of v1 for web-extension and e10s)

https://stephanmahieu.github.io/fhc-home

MIT License

51 stars 14 forks source link

Form history lost under some circumstances with a test case #72

Open birdie-github opened 4 years ago

birdie-github commented 4 years ago

Steps to reproduce:

1) Sign up at https://news.ycombinator.com/ 2) Open concurrently two comment forms for different comments 3) Fill them both with different replies, wait for a few minutes just in case 4) Close the browser 5) Open the browser again

Result: only one of the fields will be present in the database - the other one is lost for some reasons. That's quite nasty. Please fix.

stephanmahieu commented 3 years ago

The cause of this issue is the fact that FHC does not distinguish between input fields of the same website when the input fields have identical identifiers and are being used simultaneously in different tabs or windows. FHC will store formhistory for the field you are currently editing, when switching to another replica the formhistory for that input field will overwrite the one entry in the formhistory datastore.

dumblob commented 2 years ago

This has hit me also. Any plans to distinguish the fields?