[perf] Use indexOf instead of replace in ELTools#getCoreValueExpression

stephanrauh / AngularFaces

AngularFaces is a JSF library making it easy to integrate AngularJS code.

https://www.angularfaces.net

Apache License 2.0

90 stars 39 forks source link

[perf] Use indexOf instead of replace in ELTools#getCoreValueExpression #22

Closed tandraschko closed 10 years ago

tandraschko commented 10 years ago

its safer and performs better

stephanrauh commented 10 years ago

Yeah, you're right - that's a nice source of potential bugs :).

stephanrauh commented 10 years ago

AngularFaces now uses a regular expression to recognize the EL term. Maybe this version isn't not faster, but less prone to false replacements (albeit the regular expression doesn't cover every case yet)..