Closed Wisdomb33r closed 5 months ago
It's only four months ago and I've already forgotten why I removed it... but I remember I considered it an annoying attribute almost from start. In November 2022, I switch the default value to true
. Since then, the attribute was essentially useless. If you add the translations to the index.html
, they've got priority, anyways.
Talking of which: pdf.js has migrated to a different i18n library, so I'm not sure if that still works. However, I suspect nobody is using this approach. It shaves off two requests, but that's almost negligible given that the JavaScript libraries are so huge.
Ah, my readme file says that inlined translations are gone for good. And memory returns. At some point in time, I began to feel there's no point in supporting a feature nobody's using, and when pdf.js started using the *.ftl files, the old inlined translations were broken, anyways, so I decided to remove the feature.
I've found two mentions of the attribute and removed them. Thank you very much for pointing this out!
Describe the bug The troubleshooting documentation (pdfviewer.net) still states in the
Localization
chapter :It might be good to update this description, which seems obsolete. Btw, was the parameter removed because the library now always load in the browser locale, at least if not instructed otherwise by the
language
parameter ?Version info