search

stephanrauh / ngx-extended-pdf-viewer

A full-blown PDF viewer for Angular 16, 17, and beyond
https://pdfviewer.net
Apache License 2.0
449 stars 167 forks source link

Support for Angular 18 #2348

Closed JGrancha closed 4 weeks ago

JGrancha commented 1 month ago

A few days ago the new version 18 came out but in version 20.2 and version 20.5.0-alpha.0 an error appears when trying to do an npm install because the version of @angular/common@>=16.0.0 <18.0. 0

image

Do you plan to update this dependency so that it can be updated to version 18 of Angular?

Thank you

stephanrauh commented 1 month ago

What? The Angular team waits until I go to vacations, and then they publish a new version? :)

Just kidding - for some reason (possibly traveling Italy) I really missed the new version, and you're right, I ought to fix that ASAP. I ran a quick test. The library seems to be compatible to Angular 18.

In the meantime, you can use npm install --force. Of course, that's not a solution I'd recommend for production, but at least for version 20.5.0, I can promise I'll fix the issue soon. I'm not sure about version 20.2.0. If testing version 20.5.0 takes too much time, I'll have to publish a fix for version 20.2.x, but that'd be painful.

JGrancha commented 4 weeks ago

Jajajaja.

Don't worry, just being on version 20.5.0 is enough.

Thanks for the work you do.

stephanrauh commented 4 weeks ago

The bug fix has shipped with version 20.5.0-alpha.1.

Enjoy! Stephan

JGrancha commented 4 weeks ago

Thanks!!!