search

stephanrauh / ngx-extended-pdf-viewer

A full-blown PDF viewer for Angular 16, 17, and beyond
https://pdfviewer.net
Apache License 2.0
472 stars 180 forks source link

Add Antoine's eraser widget as a demo to the showcase #2505

Open stephanrauh opened 4 weeks ago

stephanrauh commented 4 weeks ago

Antoine Legrain has implemented a nice component for erasing drawings. He also kindly shared it with us. Let's try to add this to the showcase!

image

pdf-viewer.component.zip

Originally posted by @legraina in https://github.com/stephanrauh/ngx-extended-pdf-viewer/discussions/2480#discussioncomment-10342908

legraina commented 3 weeks ago

Thanks. I have a question about this eraser. I'm removing all ink annotations and then adding back the ones that have been modified. It seems that some annotations are not rendered (it's random). I suspect a timing issue, and I was wondering if I was waiting for the right event to add them back. For the moment, at initialization, I'm waiting for the first rendered event, and after erasing, I remove all ink annotations and then add the modified annotations immediately. Any idea of the cause ?

stephanrauh commented 3 weeks ago

Not really. I have to admit I'm a bit overwhelmed by the popularity of the editor features. I haven't spent much time yet reading and understanding the implementation, but you guys make me feel I should do that soon!