search

stephanstapel / BrickOwlSharp

.net library to connect to BrickOwl brick shop
MIT License
1 stars 0 forks source link

BadRequest for GetInventoryAsync with active_only set to true #2

Closed norberto5 closed 3 months ago

norberto5 commented 3 months ago

System.Net.Http.HttpRequestException: 'Received status code BadRequest for url https://api.brickowl.com:443/v1/inventory/list?active_only=True'

Based on docs, it should be either 1 or 0, not True or False

active_only (Optional) - Include only items that are for sale and have a quantity > 0. 0 or 1. Default: 1 API docs

Reproduction code: await client.GetInventoryAsync(activeOnly: true);

stephanstapel commented 3 months ago

yep, that's right:

https://github.com/stephanstapel/BrickOwlSharp/blob/1ae651df446f3ed7308ced33e30a2da02c56afd4/BrickOwlSharp.Client/BrickOwlClient.cs#L255