search

stephanstapel / ZUGFeRD-csharp

C# assembly for creating and reading ZUGFeRD invoices
Apache License 2.0
170 stars 93 forks source link

Missing ISO Codes #278

Closed PunishedSnakePr closed 3 months ago

PunishedSnakePr commented 3 months ago

How to use ISO codes (e.g. QuantityCodes) that are currently missing? As an example there is no GRM (gram) in version 12.8. Will there be a way to provide a simple string in such cases (e.g. for AddTradeLineItem)?

stephanstapel commented 3 months ago

https://github.com/stephanstapel/ZUGFeRD-csharp/blob/18b19ef01cb5848e80afc1058a5584f0cf8ffc1d/ZUGFeRD/QuantityCodes.cs#L348

PunishedSnakePr commented 3 months ago

I've seen that and I don't mean GRM specifically but what can I do if a code is generally missing in an Enum? I mean the EN16931 code list is humongous and not all codes are covered by enums. So, is there a way to bypass enums by simply providing codes as strings?

stephanstapel commented 3 months ago

If you need specific enums, I'm happy to add them. I just didn't want to add all enum values since this yields unusability. Imho it is impossible to find the right enum then.

PunishedSnakePr commented 3 months ago

Ok, thanks for the rapid answers. So, I most likely going to open a pull request with stuff I am missing.