search

stephanstapel / ZUGFeRD-csharp

C# assembly for creating and reading ZUGFeRD invoices
Apache License 2.0
170 stars 93 forks source link

UBL Writer #295

Closed shahchandra closed 2 months ago

shahchandra commented 2 months ago

Added a basic UBL writer feature. A new version "Version22UBL" added in the ZUGFeRDVersion enums for calling the UBL Writer class.

Only the basics of the attributes has been added.

stephanstapel commented 2 months ago

Hi Chandra, thanks for your pull request, this is a great addition for the library! Can you please remove the version enum entry? I'd like to use a new enum when invoking Save() instead. I can implement this tonight if you like so you can hook into that. Also, do you remember to add test cases (you might use a new .cs file for this). It'd be great if you could load one of the sample files, save them as UBL, load them again and then use the existing asserts to test if critical values are still there. It's only a basic test but better than nothing.

stephanstapel commented 2 months ago

Also, did you test the output of your writer with one of the validators?

shahchandra commented 2 months ago

Hi Chandra, thanks for your pull request, this is a great addition for the library! Can you please remove the version enum entry? I'd like to use a new enum when invoking Save() instead. I can implement this tonight if you like so you can hook into that. Also, do you remember to add test cases (you might use a new .cs file for this). It'd be great if you could load one of the sample files, save them as UBL, load them again and then use the existing asserts to test if critical values are still there. It's only a basic test but better than nothing.

Thanks for quick reply, I will remove the enum entry, and wait for your changes to implement it, in the mean time I can add the test for the write.

stephanstapel commented 2 months ago

done: https://github.com/stephanstapel/ZUGFeRD-csharp/commit/9b00d7ff826785720aad65de6ec62ee8be191e8a

shahchandra commented 2 months ago

License has been added to the new UBL Writer file

Payment means and trade line item also has been added.