search

stephanstapel / ZUGFeRD-csharp

C# assembly for creating and reading ZUGFeRD invoices
Apache License 2.0
214 stars 114 forks source link

#361 - Allowances and Charges on Document Level #363

Closed quotschmacher closed 1 month ago

stephanstapel commented 1 month ago

Could you add test cases? That help a lot for regression tests when the libraries further develops.

quotschmacher commented 1 month ago

While writing the test I saw that this problem is not 100% solveable with the existing data model. The TaxCategory - Percent hat a cardinality from 0 to 1, but in the data model it is not nullable.

https://portal3.gefeg.com/invoice/embed/indexplain?returnUrl=%2Finvoice%2Ftthome%2Findex%2F617afdc4-623f-44e0-a05b-5b878840e508%3Fpage%3D1%26useSelectedItemPosition%3Dtrue&url=https%3A%2F%2Fportal3.gefeg.com%2Fprojectdata%2Finvoice%2Fdeliverables%2Finstalled%2Fpublishingproject%2Fxrechnung%202.1.1%20-%20%28ab%2001.02.2022%29%2Fxrechnung_ubl_invoice_v2.1.1_01.02.2022.scm%2Fhtml%2Fde%2Findex.htm&pt=HTML&bc=Invoice-Portal%20validation%20-%20GEFEG%20Admin%3A%3Ahttps%3A%2F%2Fportal3.gefeg.com%2Finvoice%2Fvalidation%2CDokumentation%3A%3A%2Finvoice%2Ftthome%2Findex%2F617afdc4-623f-44e0-a05b-5b878840e508