stephematician / literanger

An update to imbs-hl/ranger for use with multiple imputation via chained equations
Other
1 stars 1 forks source link

Re-entrant beta split #5

Closed stephematician closed 1 year ago

stephematician commented 1 year ago

The beta split rule relies on the lgamma C function which may not be re-entrant. At the moment I guard against this but it makes literanger about 10x slower than ranger for this rule.

I think the simplest, most cross-platform solution, without introducing dependencies like Boost etc, would be to write a log gamma function that is re-entrant (can base this off of glibc's implementation of lgamma_r).

stephematician commented 1 year ago

Fixed in d7f058d.