Some general refactoring advice

[stephen-hqxu]

Suggestions

• There's a CMake option STP_CUDA_ARCH which essentially sets CMAKE_CUDA_ARCH, which in turn is cached and user can make changes directly, making the option STP_CUDA_ARCH pointless.
• Namespace STPDiversity can be split into a separate library, the only link between diversity engine and main engine is the STPBiomeFactory.
• Change the function insert() in STPLayerManager to emplace() for more consistent C++ standard style.

[stephen-hqxu]

Additional advice

It seems a bit redundant to have SuperError+ as a separate library, maybe join that with SuperTerrain+ and other dependencies could link to the main engine.

[stephen-hqxu]

Additional advice

• Use remove_pointer instead of hard-typed the opaque type here.

https://github.com/stephen-hqxu/superterrainplus/blob/672406bfae71c78ba7bea012a00c9fb14be7f127/SuperTerrain%2B/CoreInterface/Utility/STPSmartStream.h#L35

• It looks a bit redundant to use pointer here, simply use STPChunk as the value. This also applies to other classes like STPLayerManager and STPBiomeFactory.

https://github.com/stephen-hqxu/superterrainplus/blob/672406bfae71c78ba7bea012a00c9fb14be7f127/SuperTerrain%2B/CoreInterface/World/Chunk/STPChunkStorage.h#L57

• Group the flag and value type into the struct STPDataJitOption for simplicity, and also can be benefited from overloadded operator.

https://github.com/stephen-hqxu/superterrainplus/blob/672406bfae71c78ba7bea012a00c9fb14be7f127/SuperTerrain%2B/CoreInterface/GPGPU/STPDiversityGeneratorRTC.h#L129-L132

[stephen-hqxu]

Update

• STPDiversity cannot be split into another library because the core engine depends on it.
• I don't find it necessary to maintain standard C++ style, as long as the name sounds reasonable.

For all other suggestions, they are done :+1: