search

stephen / nodetunes

AirTunes v2 Server implementation
215 stars 64 forks source link

IPv6 support #32

Closed stephen closed 9 years ago

stephen commented 9 years ago

Closes #33

stephen commented 9 years ago

Need to figure out how to handle multiple connections racing to acquire

LinusU commented 9 years ago

Do you need help with anything specific?

stephen commented 9 years ago

I think the only thing left before this can land is figuring out what to do when two requests are attempting to connect, but neither has entered the "client connected" stage (i.e. ANNOUNCE has been written). It seems sometimes OS X at least sends two requests - one via IPv6 and one via IPv4. (This is the one test case that is currently failing)

This needs to reject -only one-, and only send a 453 if there actually is a client already connected. Might need to base it off of requester IP, or similar.

LinusU commented 9 years ago

Using requester IP makes sense, I wonder how the AirPort express is coded to handle this?