Closed microadam closed 8 years ago
microadam
commented
8 years ago OK, so it looks like this require alot more work (upgrading libalac) to get it working on 0.12 plus, so it could me merged, but will only work on 0.10 for the time being. Hadn't tested it at all on 0.12...
kylewelsby
commented
8 years ago I have traced the compatibility issue down to a single file https://github.com/stephank/node-libalac/blob/master/binding.cc as there are breaking changes between v0.10 to v0.12. Sadly I do not know enough C to upgrade this file.
microadam
commented
8 years ago Now working on 0.10, 0.12 and 4.1
sodabrew
commented
8 years ago Using this branch as the "nodetunes" dependency for airsonos works great! Thank you @microadam! Hope you will have a moment to review and merge @stephen!
stephen
commented
8 years ago Hi all, thanks for the hard work on this. Sorry for the delay - will take a look at getting this merged!
@microadam, @aspergatus - feel free to add yourselves as contributors in package.json if you like.
stephen
commented
8 years ago Thanks! Released as 0.3.0 (feel free to open a separate PR to add as contributors)
vkoi81
commented
8 years ago Thanks @stephen.
RealGandy
commented
8 years ago Has this been added to the Windows package yet? Cheers
GeorgeScottow
commented
8 years ago Is it possible to apply this fix with a current Windows package install? Thanks
macmatt43
commented
8 years ago I would also be interested in an updates Windows package or maybe some pointers as to how I can create this myself. My initial attempts at tweaking package.json in the existing Windows Pre-Build v0.0.19 did not work. Can you please let me know how to successfully incorporate nodetunes v0.3.0 into this? Many thanks
Fixes #1
Big thanks to aspergatus, wa7on and auchenberg for various pointers and their work which helped me track down where the issues were to get this working.