search

stephencelis / SQLite.swift

A type-safe, Swift-language layer over SQLite3.
MIT License
9.7k stars 1.56k forks source link

Move to GitHub Actions (instead of travis-ci.org) #1058

Closed nathanfallet closed 3 years ago

nathanfallet commented 3 years ago

The old travis.org service is no longer available. You need to activate something in order to move the CI to travis-ci.com. PRs won't be able to get merged otherwise

nathanfallet commented 3 years ago

@stephencelis It's an important point, it takes about 5 minutes, and you are the only one having the permission to do it.

nathanfallet commented 3 years ago

@jberkel I talked with Stephen today, and we concluded we had to move to GitHub Actions. We still have an unresolved error with Swift Package Manager test command swift test. Any idea of where it could come from? (all the rest is working, and this command was working previously on Travis)

image
jberkel commented 3 years ago

@NathanFallet thanks, I'll take a look. I saw that you merged some PRs, wouldn't it be better to sort out the CI before merging more code?

nathanfallet commented 3 years ago

@jberkel I only merged PRs about documentation (no CI needed) and little additions like conforming types (e.g. UUID or Int64) to codable things. I checked, and all tests are passing (except the SPM one, but others driven by Cocoapods or Carthage did), but yes, for other PRs we need to fix the CI first.

nathanfallet commented 3 years ago

Could the SPM build error be related to #1051?

jberkel commented 3 years ago

Yes, I found the problem will open a PR soon. Some of the last merged PRs broke the tests

nathanfallet commented 3 years ago

@jberkel Okay, waiting for the fix (also mark you PR to close this issue) And I just fixed what was broken by one of the last PR, because it had a conflict with another change, so even the old travis success check was wrong.