search

stephencelis / SQLite.swift

A type-safe, Swift-language layer over SQLite3.
MIT License
9.57k stars 1.54k forks source link

Adds SchemaChanger to perform database schema changes #1146

Closed jberkel closed 1 year ago

jberkel commented 1 year ago

This is mostly based on code I had already written for a personal project, which I've been meaning to integrate into SQLite for a while now. As such, it already had a bit of testing, but not much.

Open questions: should this be in SQLite.swift, or in another project? Which cases are not covered yet? What methods should be made public?

Fixes #1073

nathanfallet commented 1 year ago

Open questions: should this be in SQLite.swift, or in another project? Which cases are not covered yet? What methods should be made public?

It's a great thing to make it public, so that it's not implemented in each project, but only once, as it is standard in SQLite.

jberkel commented 1 year ago

@NathanFallet this wasn't meant to be merged yet, it's missing documentation, and some other bits

nathanfallet commented 1 year ago

@jberkel You marked it ready for review so I thought it was. I'm sorry for that. You can still publish the branch again and open a new PR for missing things.

jberkel commented 1 year ago

Ok, but I marked it as ready for review to get some feedback regarding the code, not to have it auto-merged!