search

stephencelis / SQLite.swift

A type-safe, Swift-language layer over SQLite3.
MIT License
9.57k stars 1.54k forks source link

Bump iOS minimum deployment target to 11.0 #1202

Closed danielob closed 1 year ago

danielob commented 1 year ago

I've noticed that when opening the project with Xcode 14.3, we get a warning that the target is not in the range of supported versions. Additionally, when trying to build the project using Carthage, we get a build error due to the deployment target being set to 9.0.

To address this issue, I've made changes to update the deployment target version to 11.0, which is within the range of supported deployment target versions for both Xcode and Carthage. This will ensure that the project can be built and run smoothly with the latest versions of Xcode and Carthage.

I've tested the changes locally and confirmed that they resolve the warning and error messages. Please review my changes and let me know if you have any feedback or concerns.

nathanfallet commented 1 year ago

I think you should update the podspec file as well: (EDIT: I just committed the change) https://github.com/stephencelis/SQLite.swift/blob/d7fe4499710014aa754d24ea87bedbad4bdd59d5/SQLite.swift.podspec#L21

And also, what about tvOS? (which might have the same issue)

jberkel commented 1 year ago

Don't forget about changes to documentation

nathanfallet commented 1 year ago

@danielob @jberkel Tests are not passing, I don't understand why...

jberkel commented 1 year ago

there is also this old PR which should probably be used instead: #1164

jberkel commented 1 year ago

I can look at it this weekend, I also have a project which needs to be moved to iOS 11.

jberkel commented 1 year ago

Moved to #1206