search

stephencelis / SQLite.swift

A type-safe, Swift-language layer over SQLite3.
MIT License
9.72k stars 1.57k forks source link

Change deployment targets for Xcode 15 and add dependency on custom Cocoapods fork #1255

Closed SagarSDagdu closed 6 months ago

SagarSDagdu commented 6 months ago

This PR demonstrates how to fix the issue of not being able to push podspec to Cocoapods from Xcode 15 due to minimum deployment target issues. Check this comment for more information: https://github.com/stephencelis/SQLite.swift/issues/1250#issuecomment-2053121732

SagarSDagdu commented 6 months ago

@nathanfallet iOS 12 is the minimum deployment target for Xcode 15. Ref: https://developer.apple.com/support/xcode/

Screenshot 2024-04-13 at 5 40 04 PM
nathanfallet commented 6 months ago

Yeah sorry I noticed it after asking. Also, it's marked as WIP, can this be merged? At least I'm trying to publish the update based on your branch, it's building...

SagarSDagdu commented 6 months ago

Hey @nathanfallet,this can be merged

nathanfallet commented 6 months ago

@SagarSDagdu Thank you for your time helping to solve this issue! Also note that when cocoapods will officially update to support this we will go back to the original track (so just remove Gemfile + Gemfile.lock)

SagarSDagdu commented 6 months ago

Hey @nathanfallet, it is a pleasure contributing to this repo. Yes, we can go back to the original track once Cocoapods fixes this, I will keep track of this and create a PR in the future.

nathanfallet commented 6 months ago

Also note that this one will have to be reverted at the same time (otherwise it won't work I guess) https://github.com/stephencelis/SQLite.swift/pull/1237/commits/c4ec236be4b089984c8239869309bd4c637642b6

SagarSDagdu commented 6 months ago

@nathanfallet Noted!