stephencelis / SQLite.swift

A type-safe, Swift-language layer over SQLite3.
MIT License
9.67k stars 1.56k forks source link

Add note about enabling modules in Xcode project #926

Closed skagedal closed 5 years ago

skagedal commented 5 years ago

Closes issue #925 – not an SQLite.swift issue, but an SwiftPM one, but worthy of a note here imo.

danramteke commented 5 years ago

I would prefer that we make the change that Ankit recommends here https://bugs.swift.org/browse/SR-8629

Edit: The change recommended in the link is: "the generated project starts working as expected if you rename SQLite-Bridging.h to SQLiteObjc.h."

skagedal commented 5 years ago

@danramteke Excellent, that is of course a much better solution if possible.

ypopovych commented 5 years ago

@danramteke can you provide PR for this fix?

skagedal commented 5 years ago

@ypopovych Here is a PR – just an updated version of what @danramteke provided here

skagedal commented 5 years ago

Confirmed that it works by just doing what I did here but instead pointing SwiftPM to my branch.

ypopovych commented 5 years ago

merged PR