search

stephencelis / SQLite.swift

A type-safe, Swift-language layer over SQLite3.
MIT License
9.67k stars 1.56k forks source link

If not on Swift 5+, use old datatypeValue implementation #930

Closed bdorfman closed 3 years ago

bdorfman commented 5 years ago

This fixes compiler errors when using the latest release of SQLite with Swift 4.2/Xcode 10.1 (as discussed in this issue: https://github.com/stephencelis/SQLite.swift/issues/920)

I notice the test suite is set up to only build and run with SWIFT_VERSION=5.0 To verify this fix, I manually changed the version to 4.2 and ran it in Xcode 10.1. However it might be desirable to also duplicate all test targets and have them also run on 4.2 if continued support of the previous version is desirable.

nathanfallet commented 3 years ago

@jberkel Is it planned to keep the support for Swift 4.2 and lower?

jberkel commented 3 years ago

I would prefer to move on to Swift 5.x.

nathanfallet commented 3 years ago

We dropped the support of Swift 4.2 in 0.13.0.