stephencelis / ghi

GitHub Issues on the command line. Use your $EDITOR, not your browser.
Other
2.13k stars 135 forks source link

Crash when viewing issue from mypy #325

Open refi64 opened 8 years ago

refi64 commented 8 years ago

Inside this repo:

ryan@DevPC-LX /media/ryan/stuff/mypy master $ ghi 2373
/var/lib/gems/1.9.1/gems/ghi-1.2.0/lib/ghi/commands/show.rb:52:in `pull_request?': undefined method `[]' for nil:NilClass (NoMethodError)
    from /var/lib/gems/1.9.1/gems/ghi-1.2.0/lib/ghi/commands/show.rb:35:in `execute'
    from /var/lib/gems/1.9.1/gems/ghi-1.2.0/lib/ghi/commands/command.rb:17:in `execute'
    from /var/lib/gems/1.9.1/gems/ghi-1.2.0/lib/ghi.rb:80:in `execute'
    from /var/lib/gems/1.9.1/gems/ghi-1.2.0/bin/ghi:4:in `<top (required)>'
    from /usr/local/bin/ghi:23:in `load'
    from /usr/local/bin/ghi:23:in `<main>'
ryan@DevPC-LX /media/ryan/stuff/mypy master $ 
lsloan commented 7 years ago

The equivalent command, without cloning that repo (python/mypy) locally, would be:

ghi 2373 -- python/mypy

When I run that command, it produces the following output (the contents of python/mypy#2373), which appears to be correct:

#2373: Disallow isinstance of generic expressions
@ddfisher opened this issue 108 days ago.   open  (3 comments)
 bug   priority-1-normal
Milestone #6: 0.5

    Now that runtime generics are allowed (thanks to #2302), we should prevent
    people from making calls like:

Etc.