search

stephencelis / ghi

GitHub Issues on the command line. Use your $EDITOR, not your browser.
Other
2.14k stars 142 forks source link

Remove URI.escape obsolete method calling #386

Closed neocoin closed 4 years ago

neocoin commented 4 years ago

That obsolete method calling is useless.

xtaran commented 4 years ago

Just removing it is probably not the correct fix. Over in #383 @vielmetti pointed to https://docs.knapsackpro.com/2020/uri-escape-is-obsolete-percent-encoding-your-query-string for proper replacements.

neocoin commented 4 years ago

Just removing it is probably not the correct fix. Over in #383 @vielmetti pointed to https://docs.knapsackpro.com/2020/uri-escape-is-obsolete-percent-encoding-your-query-string for proper replacements.

Yes, I read that post.

But I think (after code review). If URI#eacape is needed at that line, reference calling may be wrong.

I use ghi long time. (over 3 ~ 4 years). Unfortunately, but now I changed tool to github public cmd tool, because of this problem. :(