search

stephendade / Rpanion-server

Web-based configurator for companion computers of MAVLink vehicles
https://www.docs.rpanion.com/software/rpanion-server
GNU General Public License v3.0
143 stars 62 forks source link

Video: Send VIDEO_STREAM_INFORMATION to GCS #201

Closed ddd999 closed 7 months ago

ddd999 commented 9 months ago

Addresses feature request issue #169

Enables Rpanion to respond to send COMMAND_ACK and VIDEO_STREAM_INFORMATION messages via MavLink in response to a MAV_CMD_REQUEST_MESSAGE.

ddd999 commented 8 months ago

Converting to draft because I realized it's going to be mandatory to have a way to select the network interface and therefore, which URI gets sent in the VIDEO_STREAM_INFORMATION message. The only way to send multiple URIs would be to send multiple messages (i.e., one to every interface), which seems kludgy.

This would work fine if the URI was hardcoded to one interface (or all interfaces), but there are plenty of use cases where a user would want to choose.

stephendade commented 8 months ago

Nice! When you're ready, happy to give it test and review.

ddd999 commented 8 months ago

@stephendade, please review when you have time. Thank you!

Thanks to @TyIsI for helping with tips to get this working as well.

stephendade commented 8 months ago

Great! Looks like you'll need a rebase first, as some of my recent tlogging changes aren't in here.

ddd999 commented 8 months ago

@stephendade I had a bit of fight with git but I believe it is all up to date now.

stephendade commented 8 months ago

Yes, that look up to date now. I should have some time in the next few days to review.

ddd999 commented 7 months ago

Thanks for the review. I fixed the whitespace issues in mavManager.js and confirmed it didn't give any warnings with npm run lint. Added your suggestion for the Video page layout also--appreciate that input as I wasn't sure how to integrate the new option.

stephendade commented 7 months ago

Looks good! Merging...