search

stephenfewer / grinder

Grinder is a system to automate the fuzzing of web browsers and the management of a large number of crashes.
BSD 3-Clause "New" or "Revised" License
414 stars 131 forks source link

Add a check to see if the node server is down or not #46

Closed wchen-r7 closed 9 years ago

wchen-r7 commented 10 years ago

This PR is related to issue #40 (Node server shuts down and cannot restart). I haven't got a chance to actually look into why the node server goes down in some cases, but I feel it is definitely necessary for grinder to be able to restart the node server as long as the debugger is alive. If not, the debugging will just keep respawning the browser without any testcases.

Please note that I am not 100% familiar with grinder, so I'm not super confident if this implementation is appropriate or not. If you don't like it, please feel free to close.

stephenfewer commented 10 years ago

hey @wchen-r7 thanks for the patch, I'm going to run this on some of my nodes for a few days to test it out before merging. I still haven't found the root cause of #40 unfortunately.

wchen-r7 commented 10 years ago

Ok cool, no problem. Thanks.

mutfuzz commented 9 years ago

so i have tested this fix for the last 2~3 months on my nodes and it is working great, i no longer see dead server

please merger this PR.

stephenfewer commented 9 years ago

Awesome, thanks @wchen-r7 for the patch and thanks @mutfuzz for helping test and confirm the results!