stephenharris / Event-Organiser

WordPress plug-in, Event Organiser, development repository
http://wordpress.org/extend/plugins/event-organiser/
GNU General Public License v3.0
100 stars 76 forks source link

WP 5.6 jQuery Breaking Changes #499

Open brianjohnhanna opened 3 years ago

brianjohnhanna commented 3 years ago

In WP 5.6, the versions of jQuery and related libraries shipped with core have been upgraded to the following versions:

This appears to cause some issues with this plugin's Javascript and the bundled Fullcalendar library (v2.2.7).

Known Issues

image

Temp Fix

The WordPress core team has provided a backwards compatibility plugin which can be installed and configured to use the legacy version of jQuery. This fixes the issue with Fullcalendar. It does, however, add a large banner to every page in the admin which is less than desirable on client sites.

image


WP Version: 5.6 EO Version: 3.10.2

rbywater commented 3 years ago

Came across these issues and I managed to temporarily work around it by hacking the fullcalendar.js file to the 3.10.2 version and that restored the calendar functionality partly (albeit with some label issues etc. which is probably because there's more files that need updating than just that one).

(It should probably be noted that even with the jQuery Migrate Helper plugin installed on my 5.6 Wordpress instance, it didn't appear to mitigate any of the issues so not sure why)

stephenharris commented 3 years ago

It should be fixed in the 3.10.3 update

rbywater commented 3 years ago

Thanks @stephenharris - the 3.10.3 update fixed the zIndex issue but didn't appear to fix the second week/day issue until I hacked a new version of fullcalendar.js in. Not sure if it was just an issue at my end or not then though...

stephenharris commented 3 years ago

Thanks @rbywater - nope, I overlooked that. It should be fixed in 3.10.4

brianjohnhanna commented 3 years ago

@stephenharris thanks for jumping those fixes so quickly. I actually maintain a fork of the plugin... I see you published 3.10.4 on WP plugin repository but any chance you can publish those changes and tags here on Github so I can sync the fork?