search

stephenharris / grunt-wp-deploy

Grunt plug-in to deploy a build directory to WordPress' SVN
MIT License
64 stars 18 forks source link

Same commit message twice for each deploy #10

Closed pdewouters closed 9 years ago

pdewouters commented 10 years ago

screenshot 2014-09-02 10 04 27

stephenharris commented 10 years ago

The trunk and tag folders are committed separately, but with the same message. Additionally assets are also committed, so potentially it may appear three times.

I have to admit I never even look at WordPress' SVN repository any more, so this isn't a massive concern for me. Would a commit message such as "Committing X into Trunk/Tag" or "Tagging X" and "Committing X to trunk" be preferable?

pdewouters commented 10 years ago

Yeah, that would be acceptable :)

stephenharris commented 10 years ago

How would this fit with #9?

I feel if there's to be three separate commit messages, it might be easier to fix this as:

Other option would be to expose options for all three of these messages, but after giving it some thought, I'm not convinced of the benefit of having user-specified static messages. Potentially you could prompt the user for commit message for each...? Perhaps, also, with a flag to disable that prompt. Personally I have no interest in supplying an informative SVN messages, for the purposes of wp.org, it's not version control and not something I use beyond deploying a new version...

stephenharris commented 9 years ago

This if fixed in 1.1.0 (sorry for the delay, the update had be sitting, forgotten, on my hard drive)