search

stephenjude / filament-blog

A faceless blog content manager with configurable richtext and markdown support for filament admin panel
MIT License
147 stars 34 forks source link

Laravel Wallet contract name #8

Closed mikield closed 2 years ago

mikield commented 2 years ago

Is not better to name the interface something like WalletHolder or WalletOwner, this would perform more readable code.

class User extends Authenticatable implements Wallet

Reading this lines tells me that a User is implementing Wallet, but that's a User, how it can implement a Wallet ? :D

Hope you understand my opinion.

stephenjude commented 2 years ago

Wrong repo @mikield

mikield commented 2 years ago

That's the link that issues on Wallet repo links to.

stephenjude commented 2 years ago

Okay

stephenjude commented 2 years ago

@mikield https://github.com/stephenjude/laravel-wallet/issues