search

stephenlacy / gulp-stylus

Stylus plugin for gulp
MIT License
223 stars 60 forks source link

Replace 'makePathRelative' with 'basePath' - #109 #145

Closed revyh closed 9 years ago

revyh commented 9 years ago

The continuation of #109

@faergeek @stevelacy check out my tests, I'm not so sure about it.

stephenlacy commented 9 years ago

Thanks, can you make sure to use 2space tabs?

revyh commented 9 years ago

I was confused about indentation, because some files uses spaces, some tabs, some mixes both. So I decided to use spaces because 'index.js' uses them. If you want tabs, I can amend spaces only in my commit or leave it as is and make another PR with tabs in all sources.

stephenlacy commented 9 years ago

All files are supposed to use 2 spaces as a tab, not tabs. I noticed the very deep indentation here: https://github.com/stevelacy/gulp-stylus/pull/145/files#diff-e5b8495db5b34b144973178386ba5ceeR219 which is why I mentioned it. I can fix it later

stephenlacy commented 9 years ago

merged, thanks!

revyh commented 9 years ago

Oh, my inattention :confused:. Thx for the plugin.