search

stephenlacy / react-datagrid2

Because github.com/zippyui was deleted - supports react 16
MIT License
26 stars 20 forks source link

Another change in getGroupedRows #10

Closed thoriphes closed 5 years ago

thoriphes commented 5 years ago

renderData in get GroupedRows was ignoring potentially existent props.cellFactory. We have added a check for it!

stephenlacy commented 5 years ago

merged, thanks, publishing to 3.2.2

thoriphes commented 5 years ago

;-)

On Thu, Mar 7, 2019, 21:23 Steve Lacy notifications@github.com wrote:

merged, thanks, publishing to 3.2.2

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/stevelacy/react-datagrid2/pull/10#issuecomment-470679934, or mute the thread https://github.com/notifications/unsubscribe-auth/AAB7L0kFl7q0w5Sw3A_tJExeoGvruK7kks5vUXVQgaJpZM4bi-yv .

stephenlacy commented 5 years ago

@thoriphes interested in sending a pr for #9?

thoriphes commented 5 years ago

Hmmm... I think I solved that by pure css :P

But will take a look tomorrow and let you know

On Thu, Mar 7, 2019, 21:25 Steve Lacy notifications@github.com wrote:

@thoriphes https://github.com/thoriphes interested in sending a pr for

9 https://github.com/stevelacy/react-datagrid2/issues/9?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/stevelacy/react-datagrid2/pull/10#issuecomment-470680562, or mute the thread https://github.com/notifications/unsubscribe-auth/AAB7Lyn_RQJkVzgSP0v7hA1XBsjGdxG_ks5vUXXGgaJpZM4bi-yv .