search

stephenlacy / react-datagrid2

Because github.com/zippyui was deleted - supports react 16
MIT License
26 stars 20 forks source link

- Enabled selection when grouping rows #8

Closed thoriphes closed 5 years ago

thoriphes commented 5 years ago

Hi! I'm a customer of ZippyTech, with an owned license =)

We haven't yet switched to the new DataGrid, and are still using this one, and found that row selection wasn't enabled when using groupBy.

We have forked the project and done a quick change to solve it. Feel free to incorporate it to the project if you find it appropriate!

We have tried to run the tests, but it's been kinda messy =P (JSDOM versions not compatible, and lots of troubleshoting), but we have done some extensive usage during the last 3 days and is working OK.

NOTE: Only thing is, since we're updating the counter to give each row an individual index, the odd-even iterator works cross-group, which is a side effect.

stephenlacy commented 5 years ago

Thanks for the PR! One quick question, could you update the src/*jsx files instead of lib? That wat it will auto-compile to es5 for generic browser support.

Cheers!

thoriphes commented 5 years ago

Sure thing, done!

thoriphes commented 5 years ago

Sorry, didn't even notice lib was generated by build =P Went straight to edit lib for some reason. We've switched to the built version and everything looks ok!

stephenlacy commented 5 years ago

published to 3.2.1