search

stephenlb / webrtc-sdk

WebRTC Simple Calling API + Mobile SDK - A simplified approach to RTCPeerConnection for mobile and web video calling apps.
https://stephenlb.github.io/webrtc-sdk/
MIT License
853 stars 278 forks source link

Sometimes session.video is whitout a stream #58

Closed crookedbard closed 5 years ago

crookedbard commented 5 years ago

When I do repeat calls to: dial and hang-up after several tries I don’t get the video stream. Repeating the calls one more time usually fixes it.

stephenlb commented 5 years ago

If you are using V2, this is a known issue we have not been able to solve. V1 however does not seem to have this issue.

stephenlb commented 5 years ago

Also we've made some recent upgrades to V2 and you may see that these patches reduces the false video streams.

crookedbard commented 5 years ago

session.video.onloadedmetadata Does not get called when there is no video in stream.

stephenlb commented 5 years ago

Thank you for reporting these details! V1 webrtc.js requires PubNub v3 sdk.

https://cdn.pubnub.com/pubnub.min.js

On Tue, Oct 16, 2018, 1:38 AM Dainius Kreivys notifications@github.com wrote:

session.video.onloadedmetadata Does not get called when there is no video in stream.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/stephenlb/webrtc-sdk/issues/58#issuecomment-430151444, or mute the thread https://github.com/notifications/unsubscribe-auth/AACwnvkY6XRb8YaH99tNaSr3ct59r2Biks5ulZsJgaJpZM4XZUeI .

stephenlb commented 5 years ago 
<script src="https://cdn.pubnub.com/pubnub.min.js"></script>
<script src="https://stephenlb.github.io/webrtc-sdk/js/webrtc.js"></script>
crookedbard commented 5 years ago

Yeah but if I use V1 I need to rewrite all my previous code. Uncaught TypeError: phone.$ is not a function

stephenlb commented 5 years ago

Working to fix V2

stephenlb commented 5 years ago

V2 has been improved with consistency.

crookedbard commented 5 years ago

Chrome to chrome video still freezes. Caller A calls Caller B, A video is normal on both callers but B video is frozen on both callers.

stephenlb commented 5 years ago

This should be fixed with the recent race condition fix patch.

crookedbard commented 5 years ago

Still testing this fix, seems to be working far better now 👍 For now I will close this issue.