search

stephenmathieson-boneyard / grunt-obfuscator

Obfuscate nodejs projects via Grunt
7 stars 6 forks source link

support multiple targets, use grunt config standards #7

Closed alaimo closed 4 years ago

alaimo commented 9 years ago

These changes use registerMultiTask instead of registerTask to support multiple targets. The changes also leverage src and options to better conform with the recommendations in grunt's documentation. This should solve issues 4 & 6 (I think).

stephenmathieson commented 9 years ago

I don't use this anymore, and am not maintaining it. I'm generally +1 for this change, but Travis failing is scary and I believe this would be a breaking change...

/cc @iandotkelly

alaimo commented 9 years ago

Thanks for the feedback. I'll point travis at my fork and take a look. This is a breaking change but I think it makes sense. I can look into backwards compatibility but it's probably not worth the effort. I would just bump the major version. Nevertheless, I wouldn't accept the pull request until the build is stable. Great job on node-obfuscator. I've been really pleased with it so far. I'm fine using my fork if this project is dead. It's already ahead of this commit. I needed to add customizable compressor options to the task. Just noticed a couple requests for this and thought I would try to help.

alaimo commented 9 years ago

Fixed the build. This does a little more than the original pull request. Now you can override the uglify compressor defaults in the task options. I also bumped the major version since these are breaking changes. Should be safe to merge if you want. Thanks for publishing good open source software!

paambaati commented 9 years ago

@alaimo Kudos, looks fantastic!

iandotkelly commented 9 years ago

@stephenmathieson - I may merge this and bump the major revision number