search

stephenmathieson / node-sophist

Sophia binding
34 stars 4 forks source link

initial support for read stream #2

Closed deepak1556 closed 10 years ago

deepak1556 commented 10 years ago

if this is ok i will further improvise it, thanks!

stephenmathieson commented 10 years ago

This looks like it's ripped right out of level up. If we're going to feature parity, why not just make Sophist level up compatible?

Also, tests are failing :(

deepak1556 commented 10 years ago

you are proposing level-sophist ?

stephenmathieson commented 10 years ago

Yes, a level-sophist wrapper would be better.

deepak1556 commented 10 years ago

i left them if users are gonna shift from levelup to node-sophist, so they might expect similar features.

stephenmathieson commented 10 years ago

I've got a branch with my primitive stream support in it. I'll push it here and let you see what I'm thinking.

Here's my beginnings of Stream support: https://github.com/stephenmathieson/node-sophist/tree/wip-streams

deepak1556 commented 10 years ago

Thats way better and simpler!! , my bad trying hustle up things . sorry for the trouble, i will try out on your level-sophist proposal :) Thanks!

stephenmathieson commented 10 years ago

No worries, glad to have someone interested in this library :)

I don't use level-*, so I'm not all that comfortable trying to maintain compatibility with it. I'd be happy to change things around to support usage with LevelUP (e.g. #set -> #put, #delete -> #del, refactor gte, etc.), but it's not a high priority for me. Let me know what needs to be changed for level-sophist and I'll see what I can do :)