search

stephenmcd / cartridge

Ecommerce for Mezzanine
http://cartridge.jupo.org
BSD 2-Clause "Simplified" License
707 stars 299 forks source link

product_db breaks other django manage.py commands #323

Closed rodney757 closed 7 years ago

rodney757 commented 7 years ago

Django 1.10 removed the options_list of the BaseCommand class that product_db inherits.

When using Django 1.10 management commands from other apps, the product_db class throws a syntax error, preventing the use of custom django admin-commands.

322 fixes this

jerivas commented 7 years ago

Thanks RJ. The pull request is enough for tracking this problem, no need to open a separate issue.

Also, you don't need to open new PRs when you want to fix errors in your forked branch. Just continue pushing to it and they'll show up as usual.

On Mar 23, 2017 12:37 PM, "RJ Ewing" notifications@github.com wrote:

Django 1.10 removed the options_list of the BaseCommand class that product_db inherits.

When using Django 1.10 management commands from other apps, the product_db class throws a syntax error, preventing the use of custom django admin-commands.

322 https://github.com/stephenmcd/cartridge/pull/322 fixes this

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/stephenmcd/cartridge/issues/323, or mute the thread https://github.com/notifications/unsubscribe-auth/ACR8PvGj0jg2cvAv8NTcBIlYRVuOouy0ks5rorv6gaJpZM4MnMD0 .