search

stephenmcd / cartridge

Ecommerce for Mezzanine
http://cartridge.jupo.org
BSD 2-Clause "Simplified" License
709 stars 299 forks source link

Fixed bug caused by adding dictionaries instead of values. #329

Closed macornwell closed 6 years ago

macornwell commented 6 years ago

With the current version of Cartridge if you attempt to generate an invoice it throws an exception.

TypeError at /shop/invoice/1/
dict expected at most 1 arguments, got 3

This is caused because additional dictionaries are being added to the context variable in the invoice method.

This PR changes the way the key/values are transferred over to the context.

This could be a Python 2.7 vs Python 3 issue, I am not sure. (I am using Python 3).

Similar issue as been seen in the past: https://groups.google.com/forum/#!topic/mezzanine-users/nv3pxCfuUHI

molokov commented 6 years ago

I'm not seeing this problem with the original code - I can generate invoices (both HTML and PDF) fine.

I'm running: Python 3.5.2 Django 1.11.10 Mezzanine from commit 521a98c

What version of Django/Mezzanine are you attempting to run this version of Cartridge with? Which exact Python version?

macornwell commented 6 years ago

@molokov here are the stats. Python 3.5.2 Django 1.10.8 Mezzanine is at least 4.2.3

-e git://github.com/stephenmcd/Mezzanine@1d976e5ebae37fd718f60c938164c2a532aad0da#egg=Mezzanine
-e git://github.com/osiloke/mezzanine_widgets@c34a1adb41f82916c0898d392f1e1cce7cd5371f#egg=Mezzanine_Widgets
henri-hulski commented 6 years ago

@macornwell I had the same bug with the last release. But I think it's already fixed in master.