search

stephenmcd / cartridge

Ecommerce for Mezzanine
http://cartridge.jupo.org
BSD 2-Clause "Simplified" License
707 stars 299 forks source link

Missing migration for mezzanine.core Slugged #333

Closed owenh000 closed 5 years ago

owenh000 commented 5 years ago

Cartridge is missing a migration. Commit stephenmcd/mezzanine@bf872c358ec6d899a1a444f351b766c1e816fc63 changes the Slugged model slug field to non-nullable and adds the appropriate migrations for Mezzanine. However, the Cartridge Product model also includes this field by inheritance via cartridge.shop.BaseProduct, mezzanine.core.Displayable, and mezzanine.core.Slugged. Therefore Cartridge needs a corresponding migration.

For example:

$ pip3 install -U git+https://github.com/stephenmcd/mezzanine.git#egg=Mezzanine
$ pip3 install -U git+https://github.com/stephenmcd/cartridge.git#egg=Cartridge
$ pip3 install Django==1.11.18
$ mezzanine-project -a cartridge testcartridge
$ cd testcartridge
$ python3 manage.py makemigrations
[...]
You are trying to change the nullable field 'slug' on product to
non-nullable without a default...
owenh000 commented 5 years ago

I have opened pull request #334 which adds the missing migration.

github-actions[bot] commented 2 years ago

:tada: This issue has been resolved in version 1.0.0b1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: