search

stephenmcd / cartridge

Ecommerce for Mezzanine
http://cartridge.jupo.org
BSD 2-Clause "Simplified" License
709 stars 299 forks source link

Fix travis builds #338

Closed owenh000 closed 5 years ago

owenh000 commented 5 years ago

This pull request contains the necessary fixes to make the Travis builds work again. Please see the commit descriptions. Closes #335, closes #336, and closes #337.

owenh000 commented 5 years ago

Feedback is welcome, thanks!

jerivas commented 5 years ago

Hi Owen. Thanks for your work on this and the other issues!

Would you want to also contribute fixes to add support for Django 2.0 and 2.1? We want to stay compatible with whatever Django versions are currently supported (as seen in the official docs), which currently are 1.11, 2.0, and 2.1.

owenh000 commented 5 years ago

Hi Ed, thanks for merging the pull requests for the other issues.

I am interested in working on adding support for Django 2.x. However, it will depend on available time and community support. Currently, Cartridge is being tested against Django 1.8, 1.9, and 1.10, none of which are currently supported (see #337). Also, the Travis builds are failing (see #335). This pull request updates to Django 1.11 and fixes the Travis builds. Could you go ahead and merge this pull request, as it is an improvement over the current situation? Additional work on supporting Django 2.0 can come later.

Thanks!

jerivas commented 5 years ago

I wanted to see if we could get 2.0 support landed at the same time, but you're right, let's fix one thing at a time. Thanks again!

github-actions[bot] commented 2 years ago

:tada: This PR is included in version 1.0.0b1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: