stephenmcd / cartridge

Ecommerce for Mezzanine
http://cartridge.jupo.org
BSD 2-Clause "Simplified" License
709 stars 299 forks source link

Requirements missing from project_template #339

Closed owenh000 closed 5 years ago

owenh000 commented 5 years ago

Mezzanine provides a requirements.txt file in the project_template, and is therefore ready to be used with a virtualenv out-of-the-box. Cartridge lacks a requirements.txt file, so the Mezzanine requirements.txt is used and Cartridge is not automatically installed when using a virtualenv.

For example:

$ pip3 install --upgrade git+https://github.com/stephenmcd/mezzanine.git#egg=Mezzanine
$ pip3 install --upgrade git+https://github.com/stephenmcd/cartridge.git#egg=Cartridge
$ mezzanine-project -a cartridge testcartridge
$ cd testcartridge
$ virtualenv -p python3 env
$ source env/bin/activate
$ pip3 install -r requirements.txt
$ python3 manage.py runserver
[...]
ImportError: No module named 'cartridge'

Would it be reasonable to include a requirements.txt file in the template?

github-actions[bot] commented 2 years ago

:tada: This issue has been resolved in version 1.0.0b1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: